Implemented unused-private-member checker
#4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yushao2
force-pushed
the
checkers-4483
branch
2 times, most recently
from
e11c9f1
to
5639244
Compare
Pierre-Sassoulas
approved these changes
May 25, 2021
| def __my_print(self, string): | ||
| print(self.__another_secret + string) | ||
| another_obj = AnotherClass() | ||
| another_obj.__test() # this class's test should still be unused |
pylint/checkers/classes.py
Outdated
| @@ -636,6 +636,11 @@ def _has_same_layout_slots(slots, assigned_value): | |||
| "Used when a method parameter has a different name than in " | |||
| "the implemented interface or in an overridden method.", | |||
| ), | |||
| "W0238": ( | |||
| "Unused private member of class %s: %s", | |||
There was a problem hiding this comment.
Suggested change
| "Unused private member of class %s: %s", | |
| "Unused private member '%s.%s'", |
|
I found a false positive. It's not that common for python, but at times used for the singleton pattern. class MyCls:
__class_var = None
@classmethod
def set_class_var(cls, var):
cls.__class_var = var # false-positive: unused-private-member
@classmethod
def get_class_var(cls):
return cls.__class_var |
I'll look into this |
1 task
3 tasks
This was referenced Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
Implemented
unused-private-memberchecker, which is emitted when a private member of a class is defined but unusedChecks for:
Type of Changes
Related Issue
Closes #4483