Fix crash for unused-private-member when there are nested attributes
#4783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yushao2
force-pushed
the
fix-unused-private-member-4755
branch
from
42d1c2a
to
49c4bba
Compare
cdce8p
reviewed
Aug 1, 2021
| @@ -201,3 +201,19 @@ def __inner_4(): # [unused-private-member] | |||
|
|
|||
| fn_to_return = __inner_1 if flag else __inner_3(__inner_2) | |||
| return fn_to_return | |||
|
|
|||
|
|
|||
| # Test cases for crash reported in #4755 | |||
There was a problem hiding this comment.
That line is more or less obvious from the Github link below. Better to write a short description here. Something like
# https://github.com/PyCQA/pylint/issues/4755
# Nested attributes shouldn't cause crash(I would also reverse the order and put the link first.)
There was a problem hiding this comment.
Fixed this, also added a few overlooked testcases and fixed docs for some of the other test cases i've worked on.
I realise that this might bloat up this PR a little, and I'm sorry for that.
Hope it's okay 🙏
add additional test cases and docs for existing tests
cdce8p
reviewed
Aug 1, 2021
Pierre-Sassoulas
approved these changes
Aug 1, 2021
cdce8p
reviewed
Aug 1, 2021
Caused tests to fail
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Added logic to prevent checking attributes of attributes, and only check for the first level of attributes.
Closes #4755