Use correct input arg type for _bestrelpath

AUTHORS

@@ -138,6 +138,7 @@ Grigorii Eremeev (budulianin)
 Guido Wesdorp
 Guoqiang Zhang
 Harald Armin Massa
+Harshna
 Henk-Jaap Wagenaar
 Holger Kohr
 Hugo van Kemenade

changelog/8990.bugfix.rst

@@ -0,0 +1 @@
+Fix `pytest -vv` crashing with an internal exception `AttributeError: 'str' object has no attribute 'relative_to'` in some cases.

src/_pytest/pathlib.py

@@ -685,6 +685,8 @@ def bestrelpath(directory: Path, dest: Path) -> str:
 
     If no such path can be determined, returns dest.
     """
+    assert isinstance(directory, Path)
+    assert isinstance(dest, Path)
     if dest == directory:
         return os.curdir
     # Find the longest common directory.

src/_pytest/terminal.py

@@ -862,8 +862,10 @@ def _report_keyboardinterrupt(self) -> None:
                     yellow=True,
                 )
 
-    def _locationline(self, nodeid, fspath, lineno, domain):
-        def mkrel(nodeid):
+    def _locationline(
+        self, nodeid: str, fspath: str, lineno: Optional[int], domain: str
+    ) -> str:
+        def mkrel(nodeid: str) -> str:
             line = self.config.cwd_relative_nodeid(nodeid)
             if domain and line.endswith(domain):
                 line = line[: -len(domain)]
@@ -873,13 +875,12 @@ def mkrel(nodeid):
             return line
 
         # collect_fspath comes from testid which has a "/"-normalized path.
-
         if fspath:
             res = mkrel(nodeid)
             if self.verbosity >= 2 and nodeid.split("::")[0] != fspath.replace(
                 "\\", nodes.SEP
             ):
-                res += " <- " + bestrelpath(self.startpath, fspath)
+                res += " <- " + bestrelpath(self.startpath, Path(fspath))
         else:
             res = "[location]"
         return res + " "

testing/logging/test_reporting.py

@@ -1165,3 +1165,18 @@ def test_log_file_cli_subdirectories_are_successfully_created(
     result = pytester.runpytest("--log-file=foo/bar/logf.log")
     assert "logf.log" in os.listdir(expected)
     assert result.ret == ExitCode.OK
+
+
+def test_locationline_returns_best_relative_location(pytester: Pytester) -> None:
+    item = pytester.getitem("def test_func(): pass")
+    item.config.option.verbose = 2
+
+    tr = TerminalReporter(item.config)
+    path_to_test = os.path.join("unique", "path")
+    fspath = os.path.join(pytester.path, path_to_test)
+    nodeid = "nodeid::test"
+
+    result = tr._locationline(nodeid, fspath, 1, "domain")
+
+    expected_result = f"{nodeid} <- {path_to_test} "
+    assert result == expected_result