Use correct input arg type for _bestrelpath #9238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
reviewed
Oct 27, 2021
Co-authored-by: Ran Benita <ran@unusedvar.com>
Add type annotation Co-authored-by: Ran Benita <ran@unusedvar.com>
Change variable to Path object in place Co-authored-by: Ran Benita <ran@unusedvar.com>
bluetech
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Thanks @hp310780, this is good now.
As mentioned in the comment, we should remove the new test now, because with the asserts the problem is triggered by existing tests, so we don't need the new one. I will push this change myself, and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8990
_pytest.pathlib.bestrelpath(expects aPathobject).