New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise KeyError when requesting a metadata value that doesn't exist #416

Merged

jaraco merged 3 commits into main from feature/no-getitem-none

Dec 18, 2022

Member

jaraco commented Dec 17, 2022

Add test capturing that a missing key raises a KeyError. Ref PackageMetadata.__getitem__ returns None #371.
When requesting an item from metadata, if it's not present, raise a KeyError. Fixes PackageMetadata.__getitem__ returns None #371.
Update changelog.

jaraco added 3 commits

December 17, 2022 17:22


          Add test capturing that a missing key raises a KeyError. Ref #371.

f2e9c39


          When requesting an item from metadata, if it's not present, raise a K…

19fa35a

…eyError. Fixes #371.


          Update changelog.

612603c

jaraco merged commit 2d2cb83 into main

jaraco deleted the feature/no-getitem-none branch

December 18, 2022 01:12

dimbleby mentioned this pull request

handle importlib-metadata deprecation python-poetry/poetry#7774

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment