New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AppDefaults #17
Merged
Merged
Add AppDefaults #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaqiluo
force-pushed
the
enhance-default-version
branch
from
April 1, 2022 19:55
e472396
to
16b9165
Compare
paynejacob
approved these changes
Apr 4, 2022
thedadams
suggested changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things.
@thedadams Please check the latest commit that addresses your comments. |
jiaqiluo
force-pushed
the
enhance-default-version
branch
from
April 4, 2022 23:43
903473d
to
51f595a
Compare
thedadams
suggested changes
Apr 5, 2022
jiaqiluo
force-pushed
the
enhance-default-version
branch
from
April 5, 2022 00:38
51f595a
to
41efe6c
Compare
@thedadams Please check the latest commit: 41efe6c |
thedadams
suggested changes
Apr 5, 2022
jiaqiluo
force-pushed
the
enhance-default-version
branch
from
April 5, 2022 02:44
41efe6c
to
9304e9b
Compare
thedadams
approved these changes
Apr 5, 2022
…ion range to a release range and can be used to set the default release version(s) per app version(s). This PR improves the handling of HTTP errors, especially the 404 not found, from the source URL. This PR also bumps github.com/urfave/cli/v2 to v2.4.0 to fix the issue where the default value is not set for string slice flags.
jiaqiluo
force-pushed
the
enhance-default-version
branch
from
April 5, 2022 16:58
9304e9b
to
2819638
Compare
thedadams
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#36827
Problem:
We use channelserver to host rke2/k3s version information in rancher/rancher, and we need the ability to set different default versions for different rancher versions.
This ability should be general enough to support any app and not tied to Rancher.
Solution:
This PR adds the support for setting app defaults in the config file.
An example of the value looks like this
Problem:
In the case where the 404 NotFound is returned from the HTTP GET request, channelserver cannot parse the response's data and is stuck in returning errors.
Solution:
This PR adds checks for the response's status code and continues to parse the data only if it is 200.
Problem:
The default value for the flag
path-prefix
is not applied.Solution:
It is a bug in the urfave/cli module: urfave/cli#1121
This PR bumps github.com/urfave/cli/v2 to v2.4.0 to get the fix
Others Improvements: