[v1.29] Update k8s dependencies to 0.29.3 & controller runtime to 0.16.5 #62
Conversation
krunalhinguu
force-pushed
the
k8s-1.29.0
branch
2 times, most recently
from
be44738 to
f145685
Compare
krunalhinguu
changed the title
krunalhinguu
force-pushed
the
k8s-1.29.0
branch
2 times, most recently
from
750d48d to
400c567
Compare
krunalhinguu
changed the title
krunalhinguu
force-pushed
the
k8s-1.29.0
branch
from
07fe131 to
cb9a3c5
Compare
krunalhinguu
force-pushed
the
k8s-1.29.0
branch
2 times, most recently
from
06c9953 to
1c0e8cc
Compare
go.mod
Outdated
| @@ -1,28 +1,28 @@ | |||
| module github.com/rancher/lasso | |||
|
|
|||
| go 1.20 | |||
| go 1.22 | |||
There was a problem hiding this comment.
I suggest we stay on the minimum Go version possible given that lasso and by extension wrangler are used by many projects. Forcing 1.22 here would force wrangler to be 1.22 as well, which would then force rke2/k3s/rancher to also use 1.22.
It seems like the minimum version here is 1.21 (that's what k8s 1.29 requires).
@MbolotSuse This could be added to the versioning strategy ADR, or maybe the README here, or maybe both. What do you think?
There was a problem hiding this comment.
@tomleb i have migrated to go 1.22 , because we have bumped 1.22 in rancher/rancher.
Also same i have discussed with @kinarashah.
There was a problem hiding this comment.
@krunalhinguu Right, but what I'm saying is that there's multiple projects using lasso. So while rancher is on 1.22, the following aren't:
- rke2 -> 1.21
- k3s -> 1.21
- aks-operator -> 1.21
- eks-operator -> 1.21
- gke-operator -> 1.21
There was a problem hiding this comment.
@tomleb Threse three and also wrangler and some other repos i am updating to go1.22 with the process in next few PRs, Althoguh i'm not sure about rke2,k3s.
aks-operator -> 1.21
eks-operator -> 1.21
gke-operator -> 1.21
There was a problem hiding this comment.
The complete list which i am updating to go1.22
- lasso
- wrangler
- norman
- dynamiclistener
- machine
- apiserver
- steve
- eks
- aks
- gke
- rke
- rancher
There was a problem hiding this comment.
@krunalhinguu As @tomleb has noted, this is not universal to wrangler/lasso's consumers. K3s and RKE2 both use this library, and we can't guarantee that they will move to 1.22. For now Tom's comment stands - this PR should use 1.21 as this is the go version supported by k8s 1.29, and we don't want to add extra requirements on top of the upstream libraries.
There was a problem hiding this comment.
okay. let me make changes
… go 1.21 for controller-runtime
krunalhinguu
force-pushed
the
k8s-1.29.0
branch
from
1c0e8cc to
9c48383
Compare
|
@tomleb @MbolotSuse go version is changed in downgraded to go1.21. |
Update
Related