Remove controller-runtime module #66
Merged
+0
−744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This module doesn't seem to be used and is somewhat a burden:
go.mod
(duh) which means:It doesn't make sense to keep maintaining this if it's not being used, so this is an attempt to remove it.
Research
I've manually checked the following repos (and their corresponding branch of rancher 2.9, 2.8, 2.7):
Lasso is used by other projects as well (mostly via wrangler), so I also checked the following:
No usage in any of those repos.
Using sourcegraph, I don't see anything still in development within
github.com/rancher
that is using this package.Including archived repositories in the result, we can see that https://github.com/rancher/rancher-operator is using it. However this repository has been archived last year (and hasn't been touched in 3 years).
Let's see if any team responds that they need it, otherwise we can remove it.