Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove controller-runtime module #66

Merged
merged 1 commit into from
May 10, 2024

Conversation

tomleb
Copy link
Contributor

@tomleb tomleb commented Apr 19, 2024

Problem

This module doesn't seem to be used and is somewhat a burden:

It doesn't make sense to keep maintaining this if it's not being used, so this is an attempt to remove it.

Research

I've manually checked the following repos (and their corresponding branch of rancher 2.9, 2.8, 2.7):

  • apiserver
  • norman
  • steve
  • webhook
  • remotedialer
  • dynamiclistener
  • wrangler

Lasso is used by other projects as well (mostly via wrangler), so I also checked the following:

  • fleet
  • rke2
  • rke
  • aks-operator
  • eks-operator
  • gke-operator
  • k3s

No usage in any of those repos.

Using sourcegraph, I don't see anything still in development within github.com/rancher that is using this package.

Including archived repositories in the result
, we can see that https://github.com/rancher/rancher-operator is using it. However this repository has been archived last year (and hasn't been touched in 3 years).

Let's see if any team responds that they need it, otherwise we can remove it.

@tomleb tomleb requested a review from a team as a code owner April 19, 2024 17:27
@tomleb tomleb changed the title Remove controller-runtime package Remove controller-runtime module Apr 19, 2024
@brandond
Copy link
Member

brandond commented Apr 19, 2024

I suspect the idea was to ease migration to/from upstream controller-runtime by adding a translation between lasso caches and controller-runtime caches when using both in the same project... but since 54c7922 is a classic Darren direct-push-to-master commit with no PR or context in the commit message we can only guess.

Kill it with fire!

Verified

This commit was signed with the committer’s verified signature. The key has expired.
aaossa Antonio Ossa-Guerra
@tomleb tomleb force-pushed the remove-controller-runtime branch from 431ab48 to 4e52e2e Compare April 24, 2024 20:48
@MbolotSuse MbolotSuse merged commit 3fb88e5 into rancher:master May 10, 2024
@tomleb tomleb deleted the remove-controller-runtime branch May 10, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants