chore(ci): Fix failing build-lint-app workflow #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
requested review from
jgcmarins,
MateusAndrade and
mikehardy
as code owners
brentvatne
changed the title
MateusAndrade
approved these changes
Mar 22, 2024
MateusAndrade
pushed a commit
that referenced
this pull request
Mar 22, 2024
* chore(ci): Bump react-native orb * Try to fix macOS executor setup * Try again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CI is currently failing on iOS. I'm not super familiar with this CI setup, but I bumped the orb version to see if that would help. It didn't. It looks like the orb is still configured to use brew casks in a couple places, which will error on recent versions of homebrew. Additionally, we were spending some unnecessary compute minutes installing Android tools on the macOS executor that is only responsible for building for iOS. I also switched to using npm to install Detox, as they recommend in their docs, but this isn't really necessary since the job doesn't actually use Detox.
Test Plan
Let CI run