New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure HttpClientConfig#connectionProvider returns the original provider used to create HttpClient #2483
Conversation
…der used to create HttpClient Fixes #2462
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@violetagg I have a few questions. I chose the method of minimizing the change and There are two things in HttpConnectionProvider, http1 and http2, so I thought it was right to consider both(#2468). Isn't this method rather simple? Let me know if there's anything I didn't think of. I want to learn. |
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConfig.java
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConfig.java
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConnect.java
Show resolved
Hide resolved
@pderop @yangbongsoo Thanks for the review! |
Fixes #2462