add aria-expanded attribute to Collapse and UncontrolledCollapse #1627 #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 7, 2019 11:57
…op in CarouselItems See reactstrap#1536 Resolves issue where if the UncontrolledCarousel contains CarouselItems with the same src, the following react error gets emitted: ``` Warning: Encountered two children with the same key, `https://xxx.png`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version. ```
| @@ -49,7 +49,7 @@ class UncontrolledCollapse extends Component { | |||
| } | |||
|
|
|||
| render() { | |||
| return <Collapse isOpen={this.state.isOpen} {...omit(this.props, omitKeys)} />; | |||
| return <Collapse isOpen={this.state.isOpen} {...omit(this.props, omitKeys)} aria-expanded={this.state.isOpen ? 'true' : 'false'} />; | |||
There was a problem hiding this comment.
Wouldn't this cascade down to the Collapse which would use the value of it's isOpen prop similarly to add this?
|
@nylon22 You need to reset your master. Every new PR you create includes all of the other commits from the other PRs. |
|
closing in favor of #1657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
aria-expandedattribute to<Collapse />and<UncontrolledCollapse />components for accessibilitycloses #1627