Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aria-expanded attribute to Collapse and UncontrolledCollapse #1627 #1656

Closed
wants to merge 7 commits into from

Commits on Oct 7, 2019

  1. fix(UncontrolledCarousel): use item.key instead of item.src as key pr…

    …op in CarouselItems
    
    See reactstrap#1536
    
    Resolves issue where if the UncontrolledCarousel contains CarouselItems with the same src, the following react error gets emitted:
    
    ```
    Warning: Encountered two children with the same key, `https://xxx.png`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
    ```
    Tyson Warner committed Oct 7, 2019
    Copy the full SHA
    2f5eb9d View commit details
    Browse the repository at this point in the history
  2. refactor(UncontrolledCarousel): remove warning message for undefined …

    …item key
    Tyson Warner committed Oct 7, 2019
    Copy the full SHA
    81b6c5c View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Merge remote-tracking branch 'upstream/master'

    Tyson Warner committed Oct 9, 2019
    Copy the full SHA
    f6b8013 View commit details
    Browse the repository at this point in the history
  2. refactor(CarouselCaption): make captionText, captionHeader proptype a…

    … node
    Tyson Warner committed Oct 9, 2019
    Copy the full SHA
    6d5b4d0 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/master'

    Tyson Warner committed Oct 9, 2019
    Copy the full SHA
    0e8c074 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. fix(Collapse): add aria-expanded attribute

    Tyson Warner committed Oct 10, 2019
    Copy the full SHA
    6f39aa3 View commit details
    Browse the repository at this point in the history
  2. fix(UncontrolledCollapse): add aria-expanded attribute

    Tyson Warner committed Oct 10, 2019
    Copy the full SHA
    bc6faeb View commit details
    Browse the repository at this point in the history