Error fix in accordian #2666 issue fix #1

[qburst-harikrishnanp]

• Bug fix
• New feature
• Chore
• Breaking change
• There is an open issue which this change addresses
• I have read the CONTRIBUTING document.
• My commits follow the Git Commit Guidelines
• My code follows the code style of this project.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly.
• My change requires a change to Typescript typings.
  • I have updated the typings accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[qburst-harikrishnanp]

@illiteratewriter @aaronmars Please approve

[qburst-harikrishnanp]

@illiteratewriter @aaronmars Please approve

[illiteratewriter]

The classes object which contain .accordion-collapse is supposed to be in the parent of .accordion-body (Accordion Bootstrap).

@qburst-harikrishnanp Can you let us know what exactly you're trying to achieve with this particular PR?

[febababy]

@illiteratewriter
The PR is regarding the issue from #2681 to set styles to accordion-body.
There is a warning msg while using the accordion, #2666. This is due to the undefined while using setOpen props.

This PR will resolve both the above mentioned issues.

[illiteratewriter]

The current PR has the issue that it is changing the structure of how accordion works in bootstrap. In Bootstrap docs the accordion works as following:

<div class="accordion-collapse collapse">
 <div class="accordion-body">
  This is the second item's accordion body.
  </div>
</div>

As you can see, .accordion-body is the child of .accordion-collapse. But according to this PR, in the output we get something like:

<div class="collapse">
 <div class="accordion-body accordion-collapse ">
  This is the second item's accordion body.
  </div>
</div>

This also breaks the library for those who have applied classes previously, because there is a change in behavior.

The solution to this would be to add an additional prop, something like bodyClassName which can be applied to the second div. In essence, we would keep the className prop working like how it was previously and add a new prop (bodyClassName) to add custom classes to accordion body.

Modal.js implements something similar to this. You can look at it for inspiration.

Let me know if you have any questions.

[febababy]

Thanks for the input.

[febababy]

PR updated with issue fix for #2666 , reverted the changes done for #2681.