Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error fix in accordian #2666 issue fix #1 #2684

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Error fix in accordian #2666 issue fix #1 #2684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
90116b9
Error fix in accordian #2666 fix
Jan 23, 2023
4f84ad6
Merge pull request #1 from febababy/accordian_Errorfix
qburst-harikrishnanp Jan 23, 2023
84accc0
Issue fix #2681
Jan 24, 2023
7bc47e0
Merge pull request #2 from febababy/accordian_issue_2681
qburst-harikrishnanp Jan 27, 2023
51c1c2e
Merge branch 'master' into master
qburst-harikrishnanp Jan 27, 2023
b300f4a
Merge branch 'master' into master
qburst-harikrishnanp Feb 13, 2023
5bf46ca
Merge branch 'master' into master
qburst-harikrishnanp Feb 27, 2023
fd6c47a
reverting the fix done for #2681
Mar 28, 2023
3aa8481
Merge pull request #3 from febababy/accordian_issue_2681
qburst-harikrishnanp Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/UncontrolledAccordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const defaultProps = {
};

function UncontrolledAccordion({ defaultOpen, stayOpen, ...props }) {
const [open, setOpen] = useState(defaultOpen || (stayOpen ? [] : undefined));
const [open, setOpen] = useState(defaultOpen || (stayOpen ? [] : ''));
const toggle = (id) => {
if (stayOpen) {
if (open.includes(id)) {
Expand All @@ -31,7 +31,7 @@ function UncontrolledAccordion({ defaultOpen, stayOpen, ...props }) {
setOpen([...open, id]);
}
} else if (open === id) {
setOpen(undefined);
setOpen('');
} else {
setOpen(id);
}
Expand Down
2 changes: 1 addition & 1 deletion stories/examples/Accordion/AccordionExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function Example(props) {
const [open, setOpen] = useState('1');
const toggle = (id) => {
if (open === id) {
setOpen();
setOpen('');
} else {
setOpen(id);
}
Expand Down
2 changes: 1 addition & 1 deletion stories/examples/Accordion/AccordionFlushExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function Example(props) {
const [open, setOpen] = useState('');
const toggle = (id) => {
if (open === id) {
setOpen();
setOpen('');
} else {
setOpen(id);
}
Expand Down