chore(deps): bump #739
Merged
chore(deps): bump #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kanadgupta
commented
Jan 31, 2023
| @@ -1,4 +1,4 @@ | |||
| /* eslint-disable @typescript-eslint/ban-ts-comment */ | |||
| /* eslint-disable @typescript-eslint/ban-ts-comment, no-console */ | |||
There was a problem hiding this comment.
just some minor cleanup here
| * @see {@link https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables} | ||
| */ | ||
| export function isGHA() { | ||
| return isCI() && ci.GITHUB_ACTIONS; |
There was a problem hiding this comment.
Had to add this isCI() && clause to avoid false positives in a GitHub Actions test runner environment to ensure we're explicitly testing code that's specific to GHA. A few tests in __tests__/lib/fetch.test.ts started breaking when upgrading to jest@29.4... honestly this kinda threw me off all afternoon and I'm a bit confused why they were passing in the first place 😵💫
| @@ -1,5 +1,5 @@ | |||
| import type { CommandOptions } from '../lib/baseCommand'; | |||
There was a problem hiding this comment.
lint 🤔 per this thread I'm not sure if this is a bug or not (per import-js/eslint-plugin-import#2683) but I'm just gonna roll with this for now.
i'm so confused man wtf
erunion
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Before:
After:
This PR also includes a few lint-related cleanup/fixes and fixes a few tests that broke when upgrading to
jest@29.4(see #739 (comment))