Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump #739

Merged
merged 20 commits into from
Jan 31, 2023
Merged

chore(deps): bump #739

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0f7db3f
chore: bump deps
kanadgupta Jan 31, 2023
e8a3446
chore: lint
kanadgupta Jan 31, 2023
a4ca2e5
chore: remove some eslint-disables
kanadgupta Jan 31, 2023
a8b24a3
chore: does downgrading node-fetch fix it?
kanadgupta Jan 31, 2023
0f40ddc
Revert "chore: does downgrading node-fetch fix it?"
kanadgupta Jan 31, 2023
67be463
chore: try downgrading jest
kanadgupta Jan 31, 2023
49c81d3
Revert "chore: try downgrading jest"
kanadgupta Jan 31, 2023
e256efc
chore: try downgrading TS
kanadgupta Jan 31, 2023
5ba6766
Revert "chore: try downgrading TS"
kanadgupta Jan 31, 2023
852d94c
revert: restore lockfile
kanadgupta Jan 31, 2023
0a2c216
chore(deps-dev): eslint + friends
kanadgupta Jan 31, 2023
6e21c43
chore(deps): upgrade TS
kanadgupta Jan 31, 2023
c628308
chore: upgrade type-fest
kanadgupta Jan 31, 2023
21f02df
chore: upgrade jest + types
kanadgupta Jan 31, 2023
1ffc12f
Revert "chore: upgrade jest + types"
kanadgupta Jan 31, 2023
4904bd2
chore: bump more deps
kanadgupta Jan 31, 2023
ecb2b93
chore: bump ts-jest jest-extended
kanadgupta Jan 31, 2023
fdc4179
chore: bump jest
kanadgupta Jan 31, 2023
c830997
ci: some test fixes
kanadgupta Jan 31, 2023
04538a8
revert: maybe we don't actually need this?
kanadgupta Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions __tests__/lib/fetch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable @typescript-eslint/ban-ts-comment */
/* eslint-disable @typescript-eslint/ban-ts-comment, no-console */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor cleanup here

import config from 'config';
import { Headers } from 'node-fetch';

Expand All @@ -21,6 +21,7 @@ describe('#fetch()', () => {
process.env.GITHUB_RUN_ID = '1658821493';
process.env.GITHUB_RUN_NUMBER = '3';
process.env.GITHUB_SHA = 'ffac537e6cbbf934b08745a378932722df287a53';
process.env.TEST_RDME_CI = 'true';
kanadgupta marked this conversation as resolved.
Show resolved Hide resolved
spy = jest.spyOn(isCI, 'isGHA');
spy.mockReturnValue(true);
});
Expand All @@ -33,6 +34,7 @@ describe('#fetch()', () => {
delete process.env.GITHUB_RUN_ID;
delete process.env.GITHUB_RUN_NUMBER;
delete process.env.GITHUB_SHA;
delete process.env.TEST_RDME_CI;
spy.mockReset();
});

Expand Down Expand Up @@ -128,7 +130,6 @@ describe('#fetch()', () => {

await fetch(`${config.get('host')}/api/v1/some-warning`);

// eslint-disable-next-line no-console
expect(console.warn).toHaveBeenCalledTimes(0);
expect(getWarningCommandOutput()).toBe('');

Expand All @@ -142,7 +143,6 @@ describe('#fetch()', () => {

await fetch(`${config.get('host')}/api/v1/some-warning`);

// eslint-disable-next-line no-console
expect(console.warn).toHaveBeenCalledTimes(1);
expect(getWarningCommandOutput()).toBe('鈿狅笍 ReadMe API Warning: some error');

Expand All @@ -156,7 +156,6 @@ describe('#fetch()', () => {

await fetch(`${config.get('host')}/api/v1/some-warning`);

// eslint-disable-next-line no-console
expect(console.warn).toHaveBeenCalledTimes(2);
expect(getWarningCommandOutput()).toBe(
'鈿狅笍 ReadMe API Warning: some error\n\n鈿狅笍 ReadMe API Warning: another error'
Expand All @@ -172,7 +171,6 @@ describe('#fetch()', () => {

await fetch(`${config.get('host')}/api/v1/some-warning`);

// eslint-disable-next-line no-console
expect(console.warn).toHaveBeenCalledTimes(1);
expect(getWarningCommandOutput()).toBe('鈿狅笍 ReadMe API Warning: some garbage error');

Expand Down