Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allauth: add SAML integration #11262

Merged
merged 10 commits into from
May 15, 2024
Merged

Allauth: add SAML integration #11262

merged 10 commits into from
May 15, 2024

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 3, 2024 •
edited

This is mostly the basics to get SAML working,
the actual implementation code will live in .com.

  • A new type of SSO integration is now available (but isn't listed in the form users use)
  • A social application can now be linked to an SSO integration object.
  • SAML apps are not included when listing providers.

What's missing

  • Docs
  • A button or something in the login/signup views like "Login using SAML", and where users enter the organization slug.

Ref https://github.com/readthedocs/readthedocs-corporate/issues/1740.

@stsewd
Allauth: add SAML integration
bfd89dd 
This is mostly the basics to get SAML working,
the actual implementation code will live in .com.

Ref readthedocs/readthedocs-corporate#1740.
@stsewd stsewd mentioned this pull request Apr 3, 2024
Merged
@stsewd stsewd marked this pull request as ready for review April 17, 2024 00:17
@stsewd stsewd requested review from a team as code owners April 17, 2024 00:17
stsewd added a commit that referenced this pull request Apr 17, 2024
@stsewd
Docs: basic docs for SAML SSO
58c15f9 
We still need to figure out a couple of things, but I think it doesn't
hurt to have some basic docs about this feature.

Ref #11262
@stsewd stsewd mentioned this pull request Apr 17, 2024
Merged
humitos
humitos approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably OK to merge now. We can start with the next iteration after that. I understand we won't be exposing this to users to self-setup and it will be behind support requests, so 👍🏼

@stsewd stsewd merged commit a6130d3 into main May 15, 2024
5 checks passed
@stsewd stsewd deleted the saml-starts-here branch May 15, 2024 15:15
stsewd added a commit that referenced this pull request May 20, 2024
@stsewd @humitos
Docs: basic docs for SAML SSO (#11288)
58c74f0 
* Docs: basic docs for SAML SSO

We still need to figure out a couple of things, but I think it doesn't
hurt to have some basic docs about this feature.

Ref #11262

* Use a table instead

* Make attributes required

* Updates from review

---------

Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson agjohnson is a code owner automatically assigned from readthedocs/frontend

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stsewd @humitos