Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all alerts/rules compatible with multicluster mode #2596

Conversation

aruniiird
Copy link
Contributor

@aruniiird aruniiird commented May 3, 2024

Added 'managedBy' label to all the expressions to avoid any conflicting results.
These changes make sure that we don't have any 'PrometheusRuleFailures' in a multicluster mode scenario

@aruniiird aruniiird force-pushed the fix-pool-quota-queries-for-multicluster-mode branch from 41b06bd to 2ff6a8e Compare May 6, 2024 13:10
@aruniiird aruniiird changed the title Fixed 'pool-quota.rules' queries for multicluster mode Make all alerts/rules compatible with multicluster mode May 6, 2024
Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Are these rules tested on a multicluster setup?
  • Is there any difference in output after this change?

@aruniiird
Copy link
Contributor Author

  • Are these rules tested on a multicluster setup?

Tested all the queries on a normal (single mode) internal cluster.
Will check on a multicluster scenario.

  • Is there any difference in output after this change?

Many queries, which are changed here, won't be working properly in a multicluster mode. So now, with the changes, all the queries are supposed to give proper output (without triggering any PrometheusAlertFailure errors).
All the output will be backward compatible as all the existing fields will still be there.

Added 'managedBy' label and 'rook-ceph-mgr-external' job
to expressions (where it was needed) to avoid any
conflicting results. These changes make sure that we don't
have any 'PrometheusRuleFailures' in a multicluster mode
scenario

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@aruniiird aruniiird force-pushed the fix-pool-quota-queries-for-multicluster-mode branch from 2ff6a8e to 31820dc Compare May 13, 2024 15:17
@aruniiird
Copy link
Contributor Author

  • Are these rules tested on a multicluster setup?

Now all the query changes are tested with multicluster setup and with single aws cluster.
No issues found

  • Is there any difference in output after this change?

Now, where ever possible, we are getting the external cluster results as well. An example screenshot is given below,

image

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aruniiird, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c421d34 into red-hat-storage:main May 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants