-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all alerts/rules compatible with multicluster mode #2596
Make all alerts/rules compatible with multicluster mode #2596
Conversation
41b06bd
to
2ff6a8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Are these rules tested on a multicluster setup?
- Is there any difference in output after this change?
Tested all the queries on a normal (single mode) internal cluster.
Many queries, which are changed here, won't be working properly in a multicluster mode. So now, with the changes, all the queries are supposed to give proper output (without triggering any |
Added 'managedBy' label and 'rook-ceph-mgr-external' job to expressions (where it was needed) to avoid any conflicting results. These changes make sure that we don't have any 'PrometheusRuleFailures' in a multicluster mode scenario Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2ff6a8e
to
31820dc
Compare
Now all the query changes are tested with multicluster setup and with single aws cluster.
Now, where ever possible, we are getting the external cluster results as well. An example screenshot is given below, |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aruniiird, umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c421d34
into
red-hat-storage:main
Added 'managedBy' label to all the expressions to avoid any conflicting results.
These changes make sure that we don't have any 'PrometheusRuleFailures' in a multicluster mode scenario