Fix SBO base image conflict with local registry in GH Actions #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmacik
force-pushed
the
setup-cli-merge-on-master
branch
4 times, most recently
from
a57e873
to
e265861
Compare
pmacik
changed the title
pmacik
force-pushed
the
setup-cli-merge-on-master
branch
from
e265861
to
2af8ff9
Compare
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik
force-pushed
the
setup-cli-merge-on-master
branch
from
2af8ff9
to
a401c96
Compare
|
/retest |
|
The OpenShift CI jobs failed for exeeded rate limit to docker.io, reruning |
pedjak
approved these changes
Jun 8, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jun 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
=======================================
Coverage 54.27% 54.27%
=======================================
Files 23 23
Lines 1227 1227
=======================================
Hits 666 666
Misses 473 473
Partials 88 88 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recently merged #972 introduced a conflict in the local registry set up for building the PR images and the base image used to build SBO operator image.
Changes
This PR
Testing
PR checks will do.