Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renamed yaml.extension.recommendations #906

Merged
merged 1 commit into from Mar 16, 2023
Merged

renamed yaml.extension.recommendations #906

merged 1 commit into from Mar 16, 2023

Conversation

msivasubramaniaan
Copy link
Contributor

@msivasubramaniaan msivasubramaniaan commented Mar 15, 2023 •
edited

What does this PR do?

Renamed yaml.extension.recommendations instead of yaml.recommendations.show

What issues does this PR fix or reference?

no Ref

Is it tested? How?

NA

@msivasubramaniaan
renamed yaml.extension.recommendations
84b5bb9 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan self-assigned this Mar 16, 2023
rgrunber
rgrunber approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine. Users that explicitly set the property in the previous release will have to adjust so let's just keep it consistent going forward.

@msivasubramaniaan msivasubramaniaan merged commit 907dd00 into main Mar 16, 2023
@msivasubramaniaan msivasubramaniaan deleted the refactor-yaml-recommendation-flag branch March 16, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

@gorkem gorkem Awaiting requested review from gorkem

Assignees

@msivasubramaniaan msivasubramaniaan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msivasubramaniaan @rgrunber