add support for weights in zunionstore and zinterstore #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Can you possibly add some tests for the commands added? |
djc
reviewed
Jun 30, 2022
ndd7xv
force-pushed
the
z-weights
branch
2 times, most recently
from
021d621
to
3eb9de5
Compare
djc
approved these changes
Jul 25, 2022
|
My mind is blown! I was doing the exact same thing as @ndd7xv (going through Redis in Action), realized that a version of the |
nonirosenfeldredis
pushed a commit
to nonirosenfeldredis/redis-rs
that referenced
this pull request
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #634
Let me know if there's a preferred way to adding WEIGHTS functionality (or anything else that needs to be added or changed!). I contemplated modifying the existing
zinterstoreandzunionstorefunctions, but realized that I would have to make a change toToRedisArgsif I wanted to add this functionality while maintaining the same parameters.