Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useIsomorphicLayoutEffect usage in React Native environments #2156

Merged
merged 3 commits into from Apr 14, 2024
Merged

Fix useIsomorphicLayoutEffect usage in React Native environments #2156

merged 3 commits into from Apr 14, 2024

Commits on Apr 10, 2024

  1. Fix useIsomorphicLayoutEffect in React Native environments 

      - React Native was not using `useLayoutEffect` which was causing nested component updates to not get properly batched when using the `connect` API [reduxjs#2150](reduxjs#2150).
    @aryaemami59
    aryaemami59 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5ba0d93 View commit details
    Browse the repository at this point in the history

  2. Remove nested ternary

    @aryaemami59
    aryaemami59 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    691b1a2 View commit details
    Browse the repository at this point in the history

  3. Remove useIsomorphicLayoutEffect.native.ts 

      - Since we bundle the library now, and React Native explicitly uses `useLayoutEffect`, we do not need this file anymore.
    @aryaemami59
    aryaemami59 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    fd2c5c6 View commit details
    Browse the repository at this point in the history