Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useIsomorphicLayoutEffect usage in React Native environments #2156

Merged
merged 3 commits into from Apr 14, 2024
+12 −8
Merged

Fix useIsomorphicLayoutEffect usage in React Native environments #2156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ba0d93
Fix `useIsomorphicLayoutEffect` in React Native environments
aryaemami59 Apr 10, 2024
691b1a2
Remove nested ternary
aryaemami59 Apr 10, 2024
fd2c5c6
Remove `useIsomorphicLayoutEffect.native.ts`
aryaemami59 Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/utils/useIsomorphicLayoutEffect.native.ts
View file
Open in desktop

This file was deleted.

15 changes: 12 additions & 3 deletions src/utils/useIsomorphicLayoutEffect.ts
View file
Open in desktop
Expand Up @@ -16,6 +16,15 @@ export const canUseDOM = !!(
typeof window.document.createElement !== 'undefined'
)

export const useIsomorphicLayoutEffect = canUseDOM
? React.useLayoutEffect
: React.useEffect
// Under React Native, we know that we always want to use useLayoutEffect

/**
* Checks if the code is running in a React Native environment.
*
* @see {@link https://github.com/facebook/react-native/issues/1331 Reference}
*/
export const isReactNative =
typeof navigator !== 'undefined' && navigator.product === 'ReactNative'

export const useIsomorphicLayoutEffect =
canUseDOM || isReactNative ? React.useLayoutEffect : React.useEffect