Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-pr-from-base-branch doesn't add buttons for failing checks #3699

Closed
natelaws opened this issue Nov 4, 2020 · 0 comments · Fixed by #3931
Closed

update-pr-from-base-branch doesn't add buttons for failing checks #3699

natelaws opened this issue Nov 4, 2020 · 0 comments · Fixed by #3931
Labels
bug help wanted

Comments

@natelaws
Copy link

natelaws commented Nov 4, 2020

Continued from #3155, I'm running into two new scenarios where the button isn't showing up:

  • If you don't have the required number of approvers
  • If required status checks are failing

Screen Shot 2020-11-04 at 2 59 45 PM

Screen Shot 2020-11-04 at 3 00 07 PM

A partial workaround is to switch it back to a draft PR, but thats a little awkward.

(Thanks for the great extension!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move update-pr-from-base-branch to a more reliable position refined-github/refined-github
2 participants
@natelaws @yakov116