Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update-pr-from-base-branch duplication #3929

Closed
wants to merge 4 commits into from
Closed

Conversation

yakov116
Copy link
Member

  1. LINKED ISSUES:
    Fixes Text from update-pr-from-base-branch is duplicated #3927

  2. TEST URLS:
    Add conversation-timeline-filter feature #3847 (this needed 800)
    Shorten and fix separate-draft-pr-button #3922

  3. SCREENSHOT:
    None

I went with debounce over select observer. My thinking was that this is the only issue.

@fregante
Copy link
Member

fregante commented Jan 31, 2021

Debounce delays the first API call by 800ms. Can you look into why the API call isn’t being cached? What event(s) is calling addButton 3 times?

@yakov116
Copy link
Member Author

yakov116 commented Feb 1, 2021

Looks like there are a few events that are happening. I could not figure them all out... So select-observer it is.

@fregante
Copy link
Member

fregante commented Feb 1, 2021

Can the observer’s selector be made more specific so we don’t have to use stillLoading? It should observe the final element that we need, it’s called once it’s found. No other listener should call addButton, selector observer is good specifically because we don’t have to deal with all kinds of listeners.

@yakov116
Copy link
Member Author

yakov116 commented Feb 1, 2021

Can the observer’s selector be made more specific so we don’t have to use stillLoading?

I think it could will check later tonight

@fregante
Copy link
Member

fregante commented Feb 1, 2021

Might be worth looking for a selector that also works on failing PRs #3699

@fregante
Copy link
Member

fregante commented Feb 1, 2021

I got an idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Text from update-pr-from-base-branch is duplicated
2 participants