Meta: Support new screenshot URLs in readme parser #7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
force-pushed
the
new-screenshots-support
branch
from
66b101c
to
1f4a750
Compare
fregante
commented
Dec 1, 2023
| @@ -0,0 +1,1137 @@ | |||
| // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html | |||
There was a problem hiding this comment.
Snapshots are a bit annoying, but I think in the past we had at least one instance of nuking the options page due to some parser mistakes.
This can also help as to double-check what is actually being extracted from the readme. Currently the only way is to check the generated bundles or opening the options page (where screenshot URLs are not immediately visible for example)
On a related note, I wonder if we should export this list to a JSON file into the repo so that it can be used.
fregante
force-pushed
the
new-screenshots-support
branch
from
143aa10
to
6f2e467
Compare
fregante
commented
Dec 1, 2023
| @@ -0,0 +1,193 @@ | |||
| [ | |||
| "action-pr-link", | |||
There was a problem hiding this comment.
This is great. We now have a static JSON file with a list of features.
This could enable things like #4493 😜
It can potentially also be transformed to a raw-text list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6000 (comment)