New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand vars in tag and name inputs #1049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Could you add a test.
You should be able to find a mention of GITHUB_ACTION
inside index.test.js
via search.
a8dc8dc
to
6a16a69
Compare
75db8d1
to
bf1195d
Compare
@jetersen Done. Tests added (after some problems do get things running 😉). Can you merge? |
name-template: 'v1.2.3 (Code name: Hello World)' | ||
tag-template: v3.4.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? Could we use some $RESOLVED_VERSION so at least the test looks sane 😓 I cannot handle that your getting one version in name and a different in tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😓 Test output looks odd, would prefer the config was aligned and the test overrides the name or tag properly.
Better? What I want to show is that once the tag gets overriden, once the name. |
Much 😅 The tests clearly shows what your looking for 🙂 |
Thank you for your contribution 🙌 |
Thank you! |
Fixes #1048