Fix logic bug when displaying history basename warning messages #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this should be merged. |
jeffreypriebe
force-pushed
the
bugfix/fix-basename-match-warning
branch
from
427e61b
to
93992e8
Compare
|
@pshrmn The ' |
This was referenced Jun 12, 2017
|
Merging as a bugfix, as per #465 (comment) |
|
Thanks for this, @jeffreypriebe 💃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if "there is a basename" but the path "has the basename" the warning would show.
Now correctly doesn't show the warning.