Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic bug when displaying history basename warning messages #485

Merged
merged 1 commit into from Jun 13, 2017
Merged

Fix logic bug when displaying history basename warning messages #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/createBrowserHistory.js
View file
Open in desktop
Expand Up @@ -60,7 +60,7 @@ const createBrowserHistory = (props = {}) => {
let path = pathname + search + hash

warning(
!(basename && hasBasename(path, basename)),
(!basename || hasBasename(path, basename)),
'You are attempting to use a basename on a page whose URL path does not begin ' +
'with the basename. Expected path "' + path + '" to begin with "' + basename + '".'
)
Expand Down
2 changes: 1 addition & 1 deletion modules/createHashHistory.js
View file
Open in desktop
Expand Up @@ -75,7 +75,7 @@ const createHashHistory = (props = {}) => {
let path = decodePath(getHashPath())

warning(
!(basename && hasBasename(path, basename)),
(!basename || hasBasename(path, basename)),
'You are attempting to use a basename on a page whose URL path does not begin ' +
'with the basename. Expected path "' + path + '" to begin with "' + basename + '".'
)
Expand Down