Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove all TypeScript references when isTypeScript is passed as false to remix.init #127

Merged
merged 1 commit into from
Aug 12, 2022
Merged

feat: remove all TypeScript references when isTypeScript is passed as false to remix.init #127

merged 1 commit into from
Aug 12, 2022

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Jul 18, 2022 •
edited

Re-submission of #63

  • Update prisma seed script to use JS
  • Cleanup include from jsconfig
  • Replace vitest config with JS version
  • Replace vitest-tsconfig-paths with js equivalent
  • Updates cypress' cy.exec calls to use JS
  • Replace mocks index with JS version

Closes #61
Closes #113

This was referenced Jul 18, 2022
Merged
Merged
Merged
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review August 6, 2022 17:23
@MichaelDeBoey
Copy link
Member Author

@kentcdodds This one is good to be merged now

kentcdodds
kentcdodds approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 7c23ab4 into remix-run:main Aug 12, 2022
@MichaelDeBoey MichaelDeBoey deleted the add-convert-to-js branch August 12, 2022 17:22
@kentcdodds kentcdodds mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

@machour machour Awaiting requested review from machour

@mcansh mcansh Awaiting requested review from mcansh

Assignees

@kentcdodds kentcdodds

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MichaelDeBoey @kentcdodds