Fix feature detection of React.startTransition #10569
Conversation
馃 Changeset detectedLatest commit: 6069e2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| // Webpack + React 17 fails to compile on the usage of `React.startTransition` or | ||
| // `React["startTransition"]` even if it's behind a feature detection of | ||
| // `"startTransition" in React`. Moving this to a constant avoids the issue :/ |
There was a problem hiding this comment.
I'd assume it's tied to the import * as React from "react" import, the more typical usage is import React from "react".
Any chance of shipping this as is to un-break consumers btw? It's having pretty broad impact
There was a problem hiding this comment.
import React from "react" is deprecated as of React 17
There was a problem hiding this comment.
Good to know! 馃憤 Either way it's likely the reason why you saw this issue here but not in other places.
|
馃 Hello there, We just published version Thanks! |
|
馃 Hello there, We just published version Thanks! |
|
Tested the application with the fix |
I'm not quite sure why the current feature detection approach wasn't sufficient 馃槙 . It works fine in
vitebut apparently has issues inwebpack. the react team doesn't do anything funny like this in theiruseSyncExternalStoreshim package and I can't imagine that has issues onwebpackand React 17.Either way, moving to a constant seems to fix the webpack compilation issue.
Closes #10566