fix(react-router-dom): fix getSearchParamsForLocation in Firefox
#10620
Conversation
🦋 Changeset detectedLatest commit: b7ed23d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @smithki, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
smithki
changed the title
TypeError related to useSearchParams() in web extension content scripts in Firefox
packages/react-router-dom/dom.ts
Outdated
| // web extensions. Relevant Bugzilla tickets: | ||
| // https://bugzilla.mozilla.org/show_bug.cgi?id=1414602 | ||
| // https://bugzilla.mozilla.org/show_bug.cgi?id=1023984 | ||
| defaultSearchParams.forEach((key) => { |
There was a problem hiding this comment.
Isn't the signature reversed here and key would be the second parameter?
This also tells me we've not got sufficient test coverage over this, so if you're interested in trying to add a test to around this against useSearchParams I'd like to get one added before we merge this. Otherwise I'll try to get some tests wired up when I have a chance.
There was a problem hiding this comment.
Isn't the signature reversed here and key would be the second parameter?
🤦♂️ Nice catch, I'll push an update.
As for tests, I'm not familiar enough with this source code to feel confident in providing new test coverage, but if you have some direction I can take a stab at it. Otherwise, it may be easier to pass that along to you in the interest of expediency.
MichaelDeBoey
changed the title
TypeError related to useSearchParams() in web extension content scripts in FirefoxgetSearchParamsForLocation in Firefox
brophdawg11
dismissed
MichaelDeBoey’s stale review
Avoiding optional chaining due to bundle size concerns
|
Thanks! |
See #10618
This implements the fix proposed here: #10618 (comment)