Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router-dom): fix getSearchParamsForLocation in Firefox #10620

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/firefox-addons-and-web-extensions-bug.md
@@ -0,0 +1,5 @@
---
"react-router-dom": patch
---

Fixes an edge-case affecting web extensions in Firefox that use `URLSearchParams` and the `useSearchParams` hook.
1 change: 1 addition & 0 deletions contributors.yml
Expand Up @@ -219,3 +219,4 @@
- yuleicul
- zheng-chuang
- holynewbie
- smithki
9 changes: 7 additions & 2 deletions packages/react-router-dom/dom.ts
Expand Up @@ -97,13 +97,18 @@ export function getSearchParamsForLocation(
let searchParams = createSearchParams(locationSearch);

if (defaultSearchParams) {
for (let key of defaultSearchParams.keys()) {
// Use `defaultSearchParams.forEach(...)` here instead of iterating of
// `defaultSearchParams.keys()` to work-around a bug in Firefox related to
// web extensions. Relevant Bugzilla tickets:
// https://bugzilla.mozilla.org/show_bug.cgi?id=1414602
// https://bugzilla.mozilla.org/show_bug.cgi?id=1023984
defaultSearchParams.forEach((_, key) => {
if (!searchParams.has(key)) {
defaultSearchParams.getAll(key).forEach((value) => {
searchParams.append(key, value);
});
}
}
});
}
brophdawg11 marked this conversation as resolved.
Show resolved Hide resolved

return searchParams;
Expand Down