Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding motion blur packaging #1392

Merged
merged 10 commits into from Oct 13, 2022

Conversation

iboshkov
Copy link

This PR addresses issue #1390. It takes the referenced repository and creates a package based on it.

Documentation is added as best as I could, need some advice on versioning and package references because no versions are published yet.

I credited the author in the docs, not sure how to do that for the package.json since the only thing I have is the GH username of @UmungoBungo 😄

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remotion ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 11:48AM (UTC)

@JonnyBurger
Copy link
Member

On first glance, everything looks pretty alright to me 🙌🏼 thanks a lot, will probably apply only minor changes tomorrow before I merge it!

@JonnyBurger
Copy link
Member

@iboshkov Can you tick the Maintainer may write to this branch checkbox?
I wanted to fix the CI, but I do not seem to be allowed to edit this pull request.

Copy link
Member

@JonnyBurger JonnyBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Thanks a lot 💙 🙌

Shipping shortly... 🚀

@JonnyBurger
Copy link
Member

@iboshkov I forgot to ask, how long do you estimate you spent on this PR? Gonna make a statistic at the end of the month 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package up <MotionBlur> component
2 participants