New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(git): blobless git #11401
feat(git): blobless git #11401
Conversation
Uses blobless git cloning instead of shallow cloning. Closes #11398
Using this repo as an example, comparing shallow to blobless:
When I re-ran this multiple times I had shallow clone vary between 1.9 and 4.5s too, but I'll go with 1.9 for now (best case). Time taken increased from 1.9s to 4.9s and disk increased from 42MB to 53MB. On the scale of things, a 3s increase is not important for such a large repo, and nor is ~10MB. Also need to consider that the shallow approach requires ref syncing/fetching later which adds to the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do some real runs to verify everything works as expected. otherwise LGTM
@viceice I think I'll wait until I update the app to v26 before merging this. Just one less thing.. |
# Conflicts: # lib/util/git/index.spec.ts # lib/util/git/index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the devel docs, as this requires git v2.26 ? Not sure aabout the version. Otherwise LGTM
Maybe I'll include this in the major release and say |
Yes, lets do it in major bump, as it's potentially breaking some self-hosted users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump node js to v14.17? We should also consider removing node v12 from engines?
If you want to do this it should go in a new PR so that it's captured in a changelog from the commit. 😉 |
Let's leave the engines-next setting for now |
🎉 This PR is included in version 27.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Uses blobless git cloning instead of shallow cloning.
Context:
Closes #11398
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: