New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(managers/gradle): allow dot annotation in version.ref #21820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Documentation update needed? Please tick accordingly
- When proposing such changes, please provide evidence like a reference to Gradle docs / code or a minimum reproduction repo that demonstrates practical viability
- I think the change should also be done here:
dependency.groupName = version.ref;
89d8800
to
e33d735
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failed code coverage
@Churro @viceice CodeCov not highlight lines that missing test case not sure what to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange indirect coverage change:
https://app.codecov.io/gh/renovatebot/renovate/pull/21820/indirect-changes
e88187b
to
cfadd1a
Compare
Signed-off-by: Jinna C <jinnatim@gmail.com>
Signed-off-by: Jinna C <jinnatim@gmail.com>
Signed-off-by: Jinna C <jinnatim@gmail.com>
Co-authored-by: Johannes Feichtner <343448+Churro@users.noreply.github.com>
Signed-off-by: Jinna C <jinnatim@gmail.com>
7ca0ccb
to
01975f1
Compare
@Churro I update as you suggested. Please review it again thanks! :) |
Signed-off-by: Jinna C <jinnatim@gmail.com>
🎉 This PR is included in version 35.71.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…t#21820) Signed-off-by: Jinna C <jinnatim@gmail.com> Co-authored-by: Johannes Feichtner <343448+Churro@users.noreply.github.com>
Changes
.
-
_
in version.ref can be a reference to the version variableContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: