Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform/bitbucket): add support for fetching release notes #22094

Merged
merged 87 commits into from Jul 3, 2023
Merged

feat(platform/bitbucket): add support for fetching release notes #22094

merged 87 commits into from Jul 3, 2023

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented May 11, 2023 •
edited

Changes

Implement fetching of release-note for Bitbucket.

Context

Closes #14964

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy marked this pull request as draft May 11, 2023 13:45
@setchy
Copy link
Collaborator Author

setchy commented May 11, 2023 •
edited

Functional implementation of release note fetching for Bitbucket. Supports both changelog filenames and git tags.

Some observations while implementing

  • i can definitely see why Major overhaul of changelog retrieval #14138 is recommended 🤯
  • made the choice to add getTags and getReleaseNotesMd api functions to modules/platform/bitbucket/index.ts instead of update/pr/changelog/<<platform>> (existing github and gitlab logic). This made most sense to me.
  • wanted to leave any refactoring which impacted the other platforms for a follow-up PR so as not to increase scope of this one

I'll await some initial feedback before shifting gears to unit-tests

@setchy setchy requested review from rarkins and viceice May 11, 2023 15:44
viceice
viceice reviewed May 11, 2023
View reviewed changes
lib/modules/platform/bitbucket/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/bitbucket/index.ts Outdated Show resolved Hide resolved
lib/util/http/bitbucket.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/release-notes.ts Outdated Show resolved Hide resolved
@setchy setchy mentioned this pull request May 12, 2023
Merged
6 tasks
@setchy setchy requested review from viceice and secustor May 14, 2023 12:02
@setchy
Copy link
Collaborator Author

setchy commented May 14, 2023 •
edited

Updated to address feedback.

If it looks OK, I'll start on the unit-tests

@setchy setchy added platform:bitbucket Bitbucket Cloud platform core:changelogs Related to changelogs/release notes fetching labels May 14, 2023
@setchy setchy requested a review from viceice July 2, 2023 13:16
viceice
viceice reviewed Jul 2, 2023
View reviewed changes
lib/workers/repository/update/pr/changelog/bitbucket/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/bitbucket/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/bitbucket/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/bitbucket/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/bitbucket/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/bitbucket/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/bitbucket/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/bitbucket/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/bitbucket/source.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/changelog/bitbucket/index.ts Show resolved Hide resolved
@setchy setchy requested a review from viceice July 2, 2023 14:26
@setchy setchy requested a review from viceice July 2, 2023 18:13
@setchy setchy mentioned this pull request Jul 3, 2023
Closed
6 tasks
@secustor secustor enabled auto-merge July 3, 2023 11:23
@secustor secustor added this pull request to the merge queue Jul 3, 2023
Merged via the queue into renovatebot:main with commit b3424c6 Jul 3, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.159.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@setchy setchy deleted the feature/14964-bitbucket-release-notes branch July 3, 2023 11:52
@setchy setchy restored the feature/14964-bitbucket-release-notes branch July 3, 2023 11:52
@HonkingGoose HonkingGoose mentioned this pull request Jul 3, 2023
Merged
6 tasks
@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@secustor secustor secustor approved these changes

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
core:changelogs Related to changelogs/release notes fetching platform:bitbucket Bitbucket Cloud platform type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitbucket Cloud: include Release Notes in Renovate PRs
4 participants
@setchy @renovate-release @viceice @secustor