Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/npm): support parsing lockfileVersion=3 #22281

Merged
merged 26 commits into from Jun 6, 2023
Merged

feat(manager/npm): support parsing lockfileVersion=3 #22281

merged 26 commits into from Jun 6, 2023

Conversation

mjunker
Copy link
Contributor

@mjunker mjunker commented May 17, 2023 •
edited by viceice

Changes

Implemented support for package-lock lockfileversion3 which is created by npm >9.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@mjunker mjunker changed the title Feat/npm: support parsing lockfileVersion=3 feat(manager/npm): support parsing lockfileVersion=3 May 17, 2023
@rarkins rarkins requested a review from viceice May 18, 2023 06:15
@rarkins rarkins requested a review from viceice May 22, 2023 07:17
viceice
viceice reviewed May 22, 2023
View reviewed changes
lib/modules/manager/npm/extract/locked-versions.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/npm.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/npm.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/npm.spec.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice May 24, 2023 07:22
viceice
viceice reviewed May 24, 2023
View reviewed changes
lib/modules/manager/npm/extract/npm.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/npm.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed May 24, 2023
View reviewed changes
lib/modules/manager/npm/extract/schema.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/schema.ts Outdated Show resolved Hide resolved
@zharinov zharinov self-requested a review May 24, 2023 09:24
@zharinov zharinov mentioned this pull request May 24, 2023
Merged
6 tasks
zharinov
zharinov suggested changes May 24, 2023
View reviewed changes
lib/modules/manager/npm/extract/schema.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/extract/schema.ts Outdated Show resolved Hide resolved
mjunker and others added 5 commits May 24, 2023 12:57
@mjunker @viceice
Update lib/modules/manager/npm/extract/npm.spec.ts
6820a53 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@mjunker @viceice
Update lib/modules/manager/npm/extract/npm.ts
a219b73 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@mjunker @zharinov
Update lib/modules/manager/npm/extract/schema.ts
d9b801a 
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
@mjunker
Merge branch 'main' into feat/merge_lockfile3
47bdb93
@mjunker @zharinov
Update lib/modules/manager/npm/extract/schema.ts
52aee73 
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
@zharinov zharinov self-requested a review May 30, 2023 08:14
@mjunker mjunker dismissed a stale review via 263f64c May 30, 2023 09:19
@mjunker
Copy link
Contributor Author

mjunker commented May 31, 2023

@zharinov @viceice do you know why the test and lint result is not updated?

@rarkins rarkins enabled auto-merge June 5, 2023 05:56
@rarkins rarkins requested a review from viceice June 5, 2023 05:56
@rarkins rarkins added this pull request to the merge queue Jun 6, 2023
Merged via the queue into renovatebot:main with commit bbd3c60 Jun 6, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.113.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mugioka mugioka mentioned this pull request Jun 21, 2023
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zharinov zharinov zharinov approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm: support parsing lockfileVersion=3
5 participants
@mjunker @renovate-release @zharinov @viceice @rarkins