New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gitlabci): Update local include files #8810
Conversation
@rarkins I think we should merge |
And what should we do for the things mentioned here #8810 (comment)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs deconflicting
first finish this, then merge managers in separate pr |
@viceice sorry for my late response, I had to finish some internal stuff. I've added a seen file list to prevent an endless loop as requested by you. |
If local files are imported from the GitLab CI YAML file, the dependencies will be recognized but not updated by renovate. Renovate needs to respect the 'include:local' imports and update the depedependencies in those files. `extractPackageFile` is replaced by `extractAllPackageFiles` since the functionality of those two functions are the same. Related to renovatebot#6745 Fixes renovatebot#6713
} | ||
} | ||
|
||
const result = extractPackageFile(content); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HonkingGoose Please open a new issue:
Refactor extractPackageFile
to use js-yaml
and reuse already parsed object from extractAllPackageFiles
.
So we should extract a new function parseDoc
to be reused by both extract functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, see #9115. 😉
🎉 This PR is included in version 24.80.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
This PR fixes the problems as described in #6713 where the
include:local
blocks from the GitLab CI YAML file where ignored by renovate.Context:
Fixes #6713
Reimplementation of #8805.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: