Merge pull request #1743 from simov/fix-default-options

Fix options not being initialized in defaults method
request · Aug 21, 2015 · f1537d6 · f1537d6
2 parents 58e8f53 + 39e2bb2
commit f1537d6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -105,6 +105,8 @@ function wrapRequestMethod (method, options, requester, verb) {
 request.defaults = function (options, requester) {
   var self = this
 
+  options = options || {}
+
   if (typeof options === 'function') {
     requester = options
     options = {}

diff --git a/tests/test-defaults.js b/tests/test-defaults.js
@@ -312,6 +312,14 @@ tape('invoke convenience method from defaults', function(t) {
   })
 })
 
+tape('defaults without options', function(t) {
+  var d = request.defaults()
+  d.get(s.url + '/', {json: true}, function (e, r, b) {
+    t.equal(r.statusCode, 200)
+    t.end()
+  })
+})
+
 tape('cleanup', function(t) {
   s.close(function() {
     t.end()