Fix errors generating coverage reports. #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server.close() is async, so treat it as such: http://nodejs.org/api/net.html#net_server_close_callback This doesn't seem to matter when test files are run in separate processes using `npm test`, but it does when they are run in the same process for the coverage report.
|
Changes Unknown when pulling bd382d3 on nylen:server-close-async into * on request:master*. |
|
Ok, this makes sense, I really haven't looked through all of the tests, I just fixed the ones that were throwing errors. |
|
Sounds good to me, want to merge this, then I'll submit another PR to change test ports to 6767? I forgot about this PR so I'm glad you commented. |
simov
added a commit
that referenced
this pull request
Jan 6, 2015
Fix errors generating coverage reports.
nylen
added a commit
to nylen/request
that referenced
this pull request
Jan 6, 2015
This is a less commonly used port than 8080 so it is less likely to conflict with other services. See discussion at request#1327.
nylen
added a commit
to nylen/request
that referenced
this pull request
Jan 6, 2015
Somehow I missed a whole bunch of these in request#1327.
nylen
added a commit
to nylen/request
that referenced
this pull request
Jan 14, 2015
This is a less commonly used port than 8080 so it is less likely to conflict with other services. See discussion at request#1327.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server.close() is async, so treat it as such:
http://nodejs.org/api/net.html#net_server_close_callback
This doesn't seem to matter when test files are run in separate
processes using
npm test, but it does when they are run in the sameprocess for the coverage report.
@simov fyi (hopefully this is the only issue with our coverage reporting)