[IGNORE] Add missing HTTPS options that were not being passed to tunnel #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From reading the code, and related work in #1373 I'm not convinced this will actually work as intended:
Can you rebase your PR off of master now that #1373 is merged, and add some tests? |
taper v0.4.0 has a workaround for tapjs/tapjs#109 and tape-testing/tape#140, a bug I was experiencing in writing some new tests.
We'll need this in a minute (because the hostname gets reset during tunneling)
The new test is doing much more than the old one was, and as far as I can tell, no one was ever running it.
The new test is doing much more than the old one was, and as far as I can tell, no one was ever running it.
Also added test cases in test-tunnel.js
brichard19
changed the title
|
Closing in favor of #1380. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds some missing HTTPS options that were not being passed to the tunnel module.
This fixes Issue 1259 where the user is prompted for the private key password when performing mutual authentication using a tunnel proxy with a password-protected private key.