Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localAddress or proxy config is lost when redirecting #1437

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/redirect.js
Expand Up @@ -138,7 +138,10 @@ Redirect.prototype.onResponse = function (response) {

request.emit('redirect')

request.init()
request.init({
localAddress:request.localAddress,
proxy:request.proxy
})

return true
}
Expand Down
64 changes: 43 additions & 21 deletions tests/test-localAddress.js
@@ -1,27 +1,49 @@
'use strict'

var request = require('../index')
, tape = require('tape')
, tape = require('tape')

tape('bind to invalid address', function (t) {
request.get({
uri: 'http://www.google.com',
localAddress: '1.2.3.4'
}, function (err, res) {
t.notEqual(err, null)
t.equal(err.message, 'bind EADDRNOTAVAIL')
t.equal(res, undefined)
t.end()
})
})

tape('bind to invalid address', function(t) {
request.get({
uri: 'http://www.google.com',
localAddress: '1.2.3.4'
}, function(err, res) {
t.notEqual(err, null)
t.equal(err.message, 'bind EADDRNOTAVAIL')
t.equal(res, undefined)
t.end()
})
tape('bind to local address', function (t) {
request.get({
uri: 'http://www.google.com',
localAddress: '127.0.0.1'
}, function (err, res) {
t.notEqual(err, null)
t.equal(res, undefined)
t.end()
})
})

tape('bind to local address', function(t) {
request.get({
uri: 'http://www.google.com',
localAddress: '127.0.0.1'
}, function(err, res) {
t.notEqual(err, null)
t.equal(res, undefined)
t.end()
})
tape('bind to local address on redirect', function (t) {
var os = require('os')
var localInterfaces = os.networkInterfaces()
var localIPS=[]
Object.keys(localInterfaces).forEach(function (ifname) {
localInterfaces[ifname].forEach(function (iface) {
if ('IPv4' !== iface.family || iface.internal !== false) {
// skip over internal (i.e. 127.0.0.1) and non-ipv4 addresses
return;
}
localIPS.push(iface.address);
});
});
request.get({
uri: 'http://google.com', //redirects to 'http://google.com'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😕 Maybe this should be redirects to https://google.com?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough, the problem is that travis doesn't have interfaces and the tests are failing :( , they are passing on my local machine but not on travis

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x4139 did you ever checked the travis-ci errors https://travis-ci.org/request/request/jobs/51369942 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or run npm test locally

localAddress: localIPS[0]
}, function (err, res) {
t.equal(err, null)
t.equal(res.request.localAddress, localIPS[0])
t.end()
})
})