localAddress or proxy config is lost when redirecting #1437
Conversation
…roxy is lost due to the reinitialization without parameters of the request object
|
@0x4139 it would be great if you can provide a test case as well. |
|
it seems that i can't bind on any interface in travis. |
|
First of all this project uses 2 space indentation, can you check that in your editor? After that you can run |
| }); | ||
| }); | ||
| request.get({ | ||
| uri: 'http://google.com', //redirects to 'http://google.com' |
There was a problem hiding this comment.
😕 Maybe this should be redirects to https://google.com?
There was a problem hiding this comment.
fair enough, the problem is that travis doesn't have interfaces and the tests are failing :( , they are passing on my local machine but not on travis
There was a problem hiding this comment.
@0x4139 did you ever checked the travis-ci errors https://travis-ci.org/request/request/jobs/51369942 ?
|
@simov sorry did not run npm test my bad. |
|
Certificates are expired |
|
@0x4139 can you pull simov@1f6fbd5 here? I removed the |
|
Closing in favor of #1460 |
the localAddress or proxy configuration is lost when redirecting because the request object is initialized with an empty configuration instead of inheriting the one that made the initial request