Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaults #1518

Merged
merged 2 commits into from Mar 30, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 16 additions & 7 deletions index.js
Expand Up @@ -99,6 +99,15 @@ request.defaults = function (options, requester) {
var params = initParams(uri, opts, callback)
params.options = extend(headerlessOptions(options), params.options)

if (typeof method === 'string') {
params.options.method = (method === 'del' ? 'DELETE' : method.toUpperCase())
method = request[method]
}

if (params.options.method === 'HEAD' && paramsHaveRequestBody(params)) {
throw new Error('HTTP HEAD requests MUST NOT include a request body.')
}

if (options.headers) {
params.options.headers = getHeaders(params, options)
}
Expand All @@ -112,13 +121,13 @@ request.defaults = function (options, requester) {
}

var defaults = wrap(self)
defaults.get = self.get
defaults.patch = self.patch
defaults.post = self.post
defaults.put = self.put
defaults.head = self.head
defaults.del = self.del
defaults.cookie = self.cookie
defaults.get = wrap('get')
defaults.patch = wrap('patch')
defaults.post = wrap('post')
defaults.put = wrap('put')
defaults.head = wrap('head')
defaults.del = wrap('del')
defaults.cookie = wrap(self.cookie)
defaults.jar = self.jar
defaults.defaults = self.defaults
return defaults
Expand Down
24 changes: 24 additions & 0 deletions tests/test-defaults.js
Expand Up @@ -314,6 +314,30 @@ tape('test only function', function(t) {
})
})

tape('invoke defaults', function(t) {
var d = request.defaults({
uri: s.url + '/get',
headers: { foo: 'bar' }
})
d({}, function (e, r, b) {
t.equal(e, null)
t.equal(b, 'TESTING!')
t.end()
})
})

tape('invoke convenience method from defaults', function(t) {
var d = request.defaults({
uri: s.url + '/get',
headers: { foo: 'bar' }
})
d.get({}, function (e, r, b) {
t.equal(e, null)
t.equal(b, 'TESTING!')
t.end()
})
})

tape('cleanup', function(t) {
s.close(function() {
t.end()
Expand Down