Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add responseStartTime timing #2352

Merged
merged 2 commits into from Aug 28, 2016
Merged

Add responseStartTime timing #2352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33aa744
Add responseStartTime timing
paulirish Aug 28, 2016
ba2d946
Add tests for responseStartTime
paulirish Aug 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions request.js
View file
Open in desktop
Expand Up @@ -958,6 +958,10 @@ Request.prototype.onRequestResponse = function (response) {
})

responseContent.on('data', function (chunk) {
if (self.timing && !self.responseStarted) {
self.responseStartTime = (new Date()).getTime()
response.responseStartTime = self.responseStartTime
}
self._destdata = true
self.emit('data', chunk)
})
Expand Down
9 changes: 7 additions & 2 deletions tests/test-timing.js
View file
Open in desktop
Expand Up @@ -27,21 +27,26 @@ tape('setup', function(t) {

tape('non-redirected request is timed', function(t) {
var options = {time: true}
request('http://localhost:' + plain_server.port + '/', options, function(err, res, body) {
var r = request('http://localhost:' + plain_server.port + '/', options, function(err, res, body) {
t.equal(err, null)
t.equal(typeof res.elapsedTime, 'number')
t.equal(typeof res.responseStartTime, 'number')
t.equal((res.elapsedTime > 0), true)
t.equal((res.responseStartTime > r.startTime), true)
t.end()
})
})

tape('redirected request is timed with rollup', function(t) {
var options = {time: true}
request('http://localhost:' + plain_server.port + '/redir', options, function(err, res, body) {
var r = request('http://localhost:' + plain_server.port + '/redir', options, function(err, res, body) {
t.equal(err, null)
t.equal(typeof res.elapsedTime, 'number')
t.equal(typeof res.responseStartTime, 'number')
t.equal((res.elapsedTime > 0), true)
t.equal((res.responseStartTime > 0), true)
t.equal((res.elapsedTime > redirect_mock_time), true)
t.equal((res.responseStartTime > r.startTime), true)
t.end()
})
})
Expand Down