Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add responseStartTime timing #2352

Merged
merged 2 commits into from Aug 28, 2016
Merged

Add responseStartTime timing #2352

merged 2 commits into from Aug 28, 2016

Conversation

paulirish
Copy link
Contributor

When time:true is set in options, elapsedTime is added to the response object.

This PR will also include responseStartTime, the timestamp when the response begins. With this moment tagged, we can now recreate a rich network waterfall of the network activity.

For example, here's a network waterfall of some project's npm install with this patch and request-capture-har:
image

@paulirish
Copy link
Contributor Author

Confirmed that the build is green once the fix in #2349 is applied.

@simov simov merged commit ba2d946 into request:master Aug 28, 2016
@simov
Copy link
Member

simov commented Aug 28, 2016

👍

@paulirish paulirish mentioned this pull request Aug 28, 2016
Open
@paulirish paulirish mentioned this pull request Sep 8, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulirish @simov