Re-enable timeout tests on Travis + other fixes #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
force-pushed
the
tests-timeout-enable-travis
branch
12 times, most recently
from
53c9b98
to
c9e0980
Compare
mscdex
force-pushed
the
tests-timeout-enable-travis
branch
14 times, most recently
from
5a3bce9
to
20eacf8
Compare
mscdex
force-pushed
the
tests-timeout-enable-travis
branch
11 times, most recently
from
9f7cfa2
to
b5350d4
Compare
mscdex
changed the title
Recent changes to timeout handling now allow these tests to pass successfully on Travis CI.
Not only does this avoid problems with the fixed port already being used on the local system, but it could also avoid cascading test failures and potential race conditions between tests.
mscdex
force-pushed
the
tests-timeout-enable-travis
branch
from
b5350d4
to
3804428
Compare
|
@simov I've moved those commits to #2431. That PR will probably need to be merged first before this PR, since the reliability of Travis depends on it. #2414 is about solving a separate, unrelated issue that I encountered locally on my own machine when running tests. I think I also saw the same issue happen on Travis at some point? Let me know if this all looks alright now. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What started out as a simple re-enabling of
tests/test-timeout.json Travis has turned into more cleanup and fixes along the way.If you want any of these commits parted out into separate PRs, let me know.
I have tested these commits on Travis many times now and each time all 4 node targets have been green, so I am fairly confident not only about
tests/test-timeout.js, but also flaky tests intests/test-pipes.js, and other random failures.One possibly "major" change included here is the change in timeout behavior. IMHO the timeout changes (in request.js) I've provided here more accurately reflect the intended behavior.