Improve timeouts accuracy and node v6.8.0+ compatibility #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node v6.8.0 supports a `timeout` option now, so we should explicitly delete it in case the value is < 0 (in which case node will throw an error). Handling timeouts manually for now is better for consistency with older node versions.
Prior to this commit, the connection timeout could include some amount of time that passes before the socket actually starts its connection attempt. Additionally, this commit only starts the request timeout once a connection is made. This helps to prevent an issue where one kind of timeout is seen instead of another (ETIMEDOUT vs ESOCKETTIMEOUT) while connecting in some situations (depending on OS and possibly node version).
|
FWIW the flaky CI failure here is fixed by the relevant commit in #2415. |
pulkitsinghal
added a commit
to ShoppinPal/vend-nodejs-sdk
that referenced
this pull request
Sep 15, 2017
## Motivation - Some upstream projects that use `vend-nodejs-sdk` were facing strange issues where long-running use (after 47 minutes or so) led so a situation where nodejs would just hang after a POST request. - There weren't any clear CPU or Memory consumption red flags. - It seemed more like a bad promise chain or failing to invoke a callback that often leads nodejs into a forever running state and there's nothing really going on. ## Solution Look at the [CHANGELOG](https://github.com/request/request/blob/master/CHANGELOG.md) for `request` and see if any plausible reasons for trying a module update. 1. request/request#2431 2. request/request#2414 3. request/request#2447 4. request/request#2448 This wasn't an exact science but their descriptions seemed to merit the dependency upgrade as "at least worth a try" ## Consequences Dropped support for Node 0.10 request/request#2381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a timeout-related compatibility issue with node v6.8.0+ and makes the connection and request/response timeout more accurate by starting them at more appropriate times.