Improve configuration of default storage #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was set using `str` with dotted path to storage, so `StorageHealthCheck.get_storage` initialize it on every call. This may lead to redundant calls to external APIs (see boto/boto3#3614) Meanwhile `django.core.files.storage.default_storage` is lazy object that can be safely used as class attribute, and single `storage` object may be reused
This was referenced Mar 17, 2023
|
@frankwiles Hello, can you please check this PR? Just curious about will I be able to use this feature soon |
Closed
|
Hi @frankwiles, could you please take a loot at this one or at #408 or #383 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was set using
strwith dotted path to storage, soStorageHealthCheck.get_storageinitialize it on every call. This may lead to redundant calls to external APIs (see boto/boto3#3614)Meanwhile
django.core.files.storage.default_storageis lazy object that can be safely used as class attribute, and singlestorageobject may be reusedAlso fixes #366